Improve: New PR Template #16968
Merged
Improve: New PR Template #16968
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @regalstreak Can you add the type of change Would be nice to have a section to write a text to be included on changelog as you can see here on |
rodrigok
reviewed
Mar 27, 2020
|
@rodrigok can you review again? Have added the changes |
rodrigok
approved these changes
May 14, 2020
ggazzo
added a commit
that referenced
this pull request
May 15, 2020
…to new/oauth_page * 'admin-refactor' of github.com:RocketChat/Rocket.Chat: [FIX] Directory search user placeholder (#17652) [NEW] Added "Add custom emoji" link to emoji picker (#16250) [FIX] Marketplace tiered pricing plan wording (#17644) [FIX] Secret Registration not properly validating Invite Token (#17618) Improve: New PR Template (#16968) Add engine versions for houston with templates (#17403) Use Users.findOneByAppId instead of querying directly (#16480) Remove unnecessary setting redefinition (#17587) Deprecate compatibility cordova setting (#17586)
ggazzo
added a commit
that referenced
this pull request
May 15, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Pressing enter on search reloads the page - admin pages (#17663) [NEW] Admin refactor Second phase (#17551) [IMPROVE] Unused styles (#17554) [FIX] Directory search user placeholder (#17652) [NEW] Added "Add custom emoji" link to emoji picker (#16250) [FIX] Marketplace tiered pricing plan wording (#17644) [FIX] Secret Registration not properly validating Invite Token (#17618) Improve: New PR Template (#16968) Add engine versions for houston with templates (#17403) Use Users.findOneByAppId instead of querying directly (#16480) Remove unnecessary setting redefinition (#17587) Deprecate compatibility cordova setting (#17586)
ggazzo
added a commit
that referenced
this pull request
May 16, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (25 commits) [FIX] Not redirecting to `First Channel After Login` on register (#17664) Regression: Pressing enter on search reloads the page - admin pages (#17663) [NEW] Admin refactor Second phase (#17551) [IMPROVE] Unused styles (#17554) [FIX] Directory search user placeholder (#17652) [NEW] Added "Add custom emoji" link to emoji picker (#16250) [FIX] Marketplace tiered pricing plan wording (#17644) [FIX] Secret Registration not properly validating Invite Token (#17618) Improve: New PR Template (#16968) Add engine versions for houston with templates (#17403) Use Users.findOneByAppId instead of querying directly (#16480) Remove unnecessary setting redefinition (#17587) Deprecate compatibility cordova setting (#17586) Hyper.sh went out of business in early 2019 (#17622) [NEW] Add Permissions to deal with Omnichannel visitor past chats history (#17580) [NEW] Add permissions to deal with Omnichannel custom fields (#17567) [FIX] Livechat iframe allow microphone and camera (#9956) [FIX] Do not allow passwords on private channels (#15642) [FIX] Mail Messages > Cannot mail own user. (#17625) [FIX] remove multiple options from dontAskMeAgain (#17514) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Let's get the PR template a fresh look. We would need suggestions from maintainers on what more or what changes would be required in the PR template. The goal should be to get as much value out of the PR description as possible. (Same as on React.Native project)
Closes issue(s)
#16967
How to test or reproduce
Open the document on a markdown editor.
Screenshots
Old
New
Types of changes
Checklist
Further comments